Add new implementation of math library (libmcs), remove math library dependency from strtod.c#460
Open
ayoopierre wants to merge 3 commits intomasterfrom
Open
Add new implementation of math library (libmcs), remove math library dependency from strtod.c#460ayoopierre wants to merge 3 commits intomasterfrom
ayoopierre wants to merge 3 commits intomasterfrom
Conversation
Summary of ChangesHello @ayoopierre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the project's mathematical capabilities by integrating a new, robust math library, 'libmcs'. This change not only broadens the range of supported mathematical functions and improves compliance with industry standards but also introduces a more modular and configurable approach to managing math implementations. The existing 'libphoenix' math code has been reorganized to coexist, providing flexibility for different project requirements and hardware constraints. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the libmcs math library (v1.3.0) as an alternative implementation for critical systems and refactors the existing libphoenix math implementation into a separate directory. It also removes the math library dependency from strtod.c. The changes include a new libm/Makefile to select between implementations and a configure script for libmcs. My review identified a few critical logic errors in the libm/Makefile and the libphoenix implementation, as well as a syntax bug in the configure script.
libm/Makefile
Outdated
| LIBM_WANT_COMPLEX ?= y | ||
|
|
||
| # Set options for denormals on the FPU | ||
| ifeq ($(LIBMCS_WANT_DAZ), y) |
There was a problem hiding this comment.
There is a variable name mismatch here. The variable defined on line 12 is LIBM_LIBMCS_DAZ, but this check uses LIBMCS_WANT_DAZ. This will cause the LIBMCS_FPU_DAZ flag to never be set correctly based on the user's choice.
ifeq ($(LIBM_LIBMCS_DAZ), y)
| while true | ||
| do | ||
| if [ -z ${extra_cflags+x} ]; then read -r extra_cflags; fi | ||
| if $($CC -c ${sizecheck} ${extra_cflags}); then |
There was a problem hiding this comment.
The use of $() here is incorrect. It will attempt to execute the output of the compiler command as a shell command. Since a successful compilation typically produces no output to stdout, this will result in a shell syntax error. It should simply execute the command and check its exit status.
if $CC -c ${sizecheck} ${extra_cflags}; then
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
196c1aa to
ebb5432
Compare
added 3 commits
February 19, 2026 16:11
JIRA: RTOS-1132
JIRA: RTOS-1132
JIRA: RTOS-1132
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
ebb5432 to
4d39af1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new implementation of math library (libmcs v1.3.0).
Description
Add new implementation of math library (libmcs), move libphoenix implementation of math library, remove dependency of strtod.c on math library. Current configuration will fail to compile on ia32 because of patches on micropython applied before compilation.
Motivation and Context
Adding complete math library implementation with extensions for critical applications
Types of changes
How Has This Been Tested?
Checklist:
Special treatment